Liked AnMals suggestion of a more beat up feel so download a metal texture from DA with scratches and scuffs, also tried to improve the stem and base of the goblet so it fitted much better.
Created some better gradients for the shape of the goblet, still used Rob A's RMA Path Blend to shape the gradients to the goblet and also Graechan Plastic or Glass Script for the Highlights.

Much better, I like it

Decided it was maybe looking more pewter than silver so gone for a lighter version

he4rty: well done!! it looks so much better now, the stem is much more in keeping with the actual cup.
i like the pewter one best - the silver is good and quite credible as silver, but the pewter goblet has more character. looks like it could hold a secret drop of poison intended for the owner but of course the owner will be distracted at the last moment before he/she puts the goblet to the lips and they will put it down again and place it on the table and rush off to investigate something of seemingly great importance - and the pewter goblet will be left standing on the table, waiting for whatever unknowing victim will come by hoping to quench their thirst...
(i got a little bit carried away. metal with an antique and somewhat beat up look frequently does that to me...)

Very nice chalice, he4rty! Both versions.

It looks really nice. I appreciate how the lighting/shadows are consistent. So many people botch that up. The only critique I would make (and it's not even about the goblet) is that the "wine" doesn't look realistic. But you may just be using it as a sort of placeholder. Anyways, my $0.02.

Thanks for all the comments, have tried to improve the wine so it looks more winey, also in turning layers on and off by mistake found a nice gold tarnished effect to the inside of the goblet that I like and this led to being able to brighten the goblet a bit but not as much as the previous version, so I kind of have something inbetween the two.

THe only thing I could think of to improve it would be to try and make the texture layer follow the contours better...maybe with page bend, up on the sides and down in the center of the layer?

Did try running a displace map but it never really worked out very well, this page bend is a plug in.

Nice work! Definitely challenging.

Elegant! Beautiful. I like them all.

Nice work He4rty.

Thanks for the comments, not been doing to much to the image today, mainly created a grid and been playing with various gradient blends and the displace map settings to try and improve the mapping of the texture.

the chalice got better and better with each new version
very cool !

especially the "improved" wine makes a big difference

he4rty: the latest version is just excellent. i like the tarnished effect on the inside and the wine does look better - though i would have made it darker, much easier to hide poison in ...

Remind me not to come round for tea, I'd be very eary what you might put in it.

The wine looks great!!