It is currently Fri Mar 29, 2024 4:55 am


All times are UTC - 5 hours [ DST ]



Post new topic Reply to topic  [ 7 posts ] 
Author Message
 Post subject: gmic-gimp-gtk and gimp 2.9.5 GIMP_STOCK_RESET issue
PostPosted: Wed Apr 05, 2017 5:18 am  (#1) 
Offline
GimpChat Member

Joined: Oct 11, 2014
Posts: 82
from discussion
https://discuss.pixls.us/t/compile-erro ... bit/3577/4

patch (trivial without check gimp version > 2.9.4):

--- a/gmic_gimp_gtk.cpp   2017-03-09 14:48:11.135929826 +0100
+++ b/gmic_gimp_gtk.cpp   2017-03-09 14:48:11.171930890 +0100
@@ -4084,7 +4084,7 @@
   g_signal_connect(maximize_button,"clicked",G_CALLBACK(on_dialog_maximize_button_clicked),0);

   GtkWidget *const reset_button = gtk_dialog_add_button(GTK_DIALOG(dialog_window),
-                                                        GIMP_STOCK_RESET,GTK_RESPONSE_NONE);
+                                                        GIMP_ICON_RESET,GTK_RESPONSE_NONE);
   g_signal_connect(reset_button,"clicked",G_CALLBACK(on_dialog_reset_clicked),0);

   GtkWidget *apply_button = gtk_dialog_add_button(GTK_DIALOG(dialog_window),


gimp code change:
https://git.gnome.org/browse/gimp/commi ... b2e54b2b54


Share on Facebook Share on Twitter Share on Orkut Share on Digg Share on MySpace Share on Delicious Share on Technorati
Top
 Post subject: Re: gmic-gimp-gtk and gimp 2.9.5 GIMP_STOCK_RESET issue
PostPosted: Wed Apr 05, 2017 6:25 am  (#2) 
Offline
GimpChat Member

Joined: Mar 04, 2011
Posts: 2414
That report was based on Debian testing. David wrote it is fixed and looks like that change is incorporated. (I think) http://i.imgur.com/jndOAmQ.jpg

I compile my own gmic_gimp_gtk for Gimp 2.9.5 using the packages from the ubuntu gimp-edge ppa. Ok that might not be the most bang-up-to-date Gimp 2.9.5, last update was 3 days ago but gmic compiled without error then.

Just updated from git, compiled again and no errors. The last time it failed to compile was the HSV/HSL issue a week or so ago and that was fixed. Just run through a few filters in gmic_gimp_gtk and all working fine.

I can post the plugin but unlikely to work on anything other than ubuntu 16.04 64bit & Gimp 2.9.5

_________________
Image


Top
 Post subject: Re: gmic-gimp-gtk and gimp 2.9.5 GIMP_STOCK_RESET issue
PostPosted: Wed Apr 05, 2017 8:12 am  (#3) 
Offline
GimpChat Member

Joined: Oct 11, 2014
Posts: 82
gmic today git

gimp:
gimp2.9 -vGNU Image Manipulation Program versione 2.9.5
git-describe: GIMP_2_9_4-1174-gdddcdb4

uso di GEGL in versione 0.3.15 (compilato con versione 0.3.15)
uso di GLib in versione 2.44.1 (compilato con versione 2.44.1)
uso di GdkPixbuf in versione 2.32.3 (compilato con versione 2.32.3)
uso di GTK+ in versione 2.24.28 (compilato con versione 2.24.28)
uso di Pango in versione 1.40.3 (compilato con versione 1.40.3)
uso di Fontconfig in versione 2.11.0 (compilato con versione 2.11.0)
uso di Cairo in versione 1.14.2 (compilato con versione 1.14.2)


gmic_gimp_gtk from source:

make gimp_gtk
make "CFLAGS+=-Dgmic_build -Dcimg_use_zlib `pkg-config --cflags zlib || echo -I/usr/include` -Dgmic_prerelease="\\\"`date +%y%m%d`\\\"" -std=c++11 -pedantic -Wall -Wextra -Wfatal-errors -Dcimg_use_vt100 -Dcimg_use_abort -Dgmic_is_parallel -Dcimg_use_fftw3 `pkg-config --cflags fftw3` -Dcimg_use_curl `pkg-config --cflags libcurl` -Dcimg_use_png `pkg-config --cflags libpng` -Dcimg_use_rng -DGIMP_DISABLE_DEPRECATED -fopenmp -Dcimg_use_openmp -Dcimg_display=1 -Dcimg_appname=\\\"gmic\\\" `pkg-config --cflags x11 || echo -I/usr/X11R6/include`  -Ofast -march=native" "LIBS+=`pkg-config --libs zlib || echo -lz` -L/usr/lib -lm -lpthread `pkg-config --libs fftw3 || echo -lfftw3` -lfftw3_threads `pkg-config --libs libcurl || echo -lcurl` `pkg-config --libs libpng || echo -lpng -lz` -lgomp `pkg-config --libs x11 || echo -L/usr/X11R6/lib -lX11` -lpthread " gmic_gimp_gtk
make[1]: ingresso nella directory "/home/mc/develop-deb/gimp-git/gimp2.9_in_opt/plugin/gmic-master/src"
> Retrieve G'MIC Standard Library... done!
> Retrieve CImg Library... done!
g++ -o gmic_gimp_gtk.o -c gmic.cpp -Dgmic_gui -Dgmic_build -Dcimg_use_zlib  -Dgmic_prerelease=\"170405\" -std=c++11 -pedantic -Wall -Wextra -Wfatal-errors -Dcimg_use_vt100 -Dcimg_use_abort -Dgmic_is_parallel -Dcimg_use_fftw3  -Dcimg_use_curl  -Dcimg_use_png -I/opt/gimp2.9/include/libpng16  -Dcimg_use_rng -DGIMP_DISABLE_DEPRECATED -fopenmp -Dcimg_use_openmp -Dcimg_display=1 -Dcimg_appname=\"gmic\"   -Ofast -march=native

g++ -o gmic_gimp_gtk gmic_gimp_gtk.cpp gmic_gimp_gtk.o -Dgmic_gui `gimptool-2.0 --cflags` `gimptool-2.0 --libs` -Dgmic_build -Dcimg_use_zlib  -Dgmic_prerelease=\"170405\" -std=c++11 -pedantic -Wall -Wextra -Wfatal-errors -Dcimg_use_vt100 -Dcimg_use_abort -Dgmic_is_parallel -Dcimg_use_fftw3  -Dcimg_use_curl  -Dcimg_use_png -I/opt/gimp2.9/include/libpng16  -Dcimg_use_rng -DGIMP_DISABLE_DEPRECATED -fopenmp -Dcimg_use_openmp -Dcimg_display=1 -Dcimg_appname=\"gmic\"   -Ofast -march=native -L/usr/lib/x86_64-linux-gnu -lz  -L/usr/lib -lm -lpthread -lfftw3  -lfftw3_threads -lcurl  -L/opt/gimp2.9/lib -lpng16  -lgomp -lX11  -lpthread
gmic_gimp_gtk.cpp: In function ‘void create_dialog_gui(bool)’:
gmic_gimp_gtk.cpp:4087:57: error: ‘GIMP_STOCK_RESET’ was not declared in this scope
                                                         GIMP_STOCK_RESET,GTK_RESPONSE_NONE);
                                                         ^
compilation terminated due to -Wfatal-errors.


gmic_gimp_gtk.cpp:4087:57: error: ‘GIMP_STOCK_RESET’ was not declared in this scope
                                                         GIMP_STOCK_RESET,GTK_RESPONSE_NONE);
                                                         ^
compilation terminated due to -Wfatal-errors.


[edit]
because GIMP_STOCK_RESET (deprecate) now is GIMP_ICON_RESET.
and -DGIMP_DISABLE_DEPRECATED in make

view:
https://git.gnome.org/browse/gimp/tree/ ... impicons.h
[\edit]

apply the GIMP_ICON_RESET patch:

cat /home/mc/develop-deb/gimp-git/gimp2.9_in_opt/plugin/gmic1.diff | patch -p1
patching file gmic_gimp_gtk.cpp

make gimp_gtk

make "CFLAGS+=-Dgmic_build -Dcimg_use_zlib `pkg-config --cflags zlib || echo -I/usr/include` -Dgmic_prerelease="\\\"`date +%y%m%d`\\\"" -std=c++11 -pedantic -Wall -Wextra -Wfatal-errors -Dcimg_use_vt100 -Dcimg_use_abort -Dgmic_is_parallel -Dcimg_use_fftw3 `pkg-config --cflags fftw3` -Dcimg_use_curl `pkg-config --cflags libcurl` -Dcimg_use_png `pkg-config --cflags libpng` -Dcimg_use_rng -DGIMP_DISABLE_DEPRECATED -fopenmp -Dcimg_use_openmp -Dcimg_display=1 -Dcimg_appname=\\\"gmic\\\" `pkg-config --cflags x11 || echo -I/usr/X11R6/include`  -Ofast -march=native" "LIBS+=`pkg-config --libs zlib || echo -lz` -L/usr/lib -lm -lpthread `pkg-config --libs fftw3 || echo -lfftw3` -lfftw3_threads `pkg-config --libs libcurl || echo -lcurl` `pkg-config --libs libpng || echo -lpng -lz` -lgomp `pkg-config --libs x11 || echo -L/usr/X11R6/lib -lX11` -lpthread " gmic_gimp_gtk
make[1]: ingresso nella directory "/home/mc/develop-deb/gimp-git/gimp2.9_in_opt/plugin/gmic-master/src"
g++ -o gmic_gimp_gtk gmic_gimp_gtk.cpp gmic_gimp_gtk.o -Dgmic_gui `gimptool-2.0 --cflags` `gimptool-2.0 --libs` -Dgmic_build -Dcimg_use_zlib  -Dgmic_prerelease=\"170405\" -std=c++11 -pedantic -Wall -Wextra -Wfatal-errors -Dcimg_use_vt100 -Dcimg_use_abort -Dgmic_is_parallel -Dcimg_use_fftw3  -Dcimg_use_curl  -Dcimg_use_png -I/opt/gimp2.9/include/libpng16  -Dcimg_use_rng -DGIMP_DISABLE_DEPRECATED -fopenmp -Dcimg_use_openmp -Dcimg_display=1 -Dcimg_appname=\"gmic\"   -Ofast -march=native -L/usr/lib/x86_64-linux-gnu -lz  -L/usr/lib -lm -lpthread -lfftw3  -lfftw3_threads -lcurl  -L/opt/gimp2.9/lib -lpng16  -lgomp -lX11  -lpthread
strip gmic_gimp_gtk
make[1]: uscita dalla directory "/home/mc/develop-deb/gimp-git/gimp2.9_in_opt/plugin/gmic-master/src"

ls -l gmic_gimp_gtk
-rwxr-xr-x 1 mc mc 6473736 apr  5 15:03 gmic_gimp_gtk


Attachment:
cap043.jpg
cap043.jpg [ 108.79 KiB | Viewed 4524 times ]


Last edited by telperion on Wed Apr 05, 2017 5:57 pm, edited 2 times in total.

Top
 Post subject: Re: gmic-gimp-gtk and gimp 2.9.5 GIMP_STOCK_RESET issue
PostPosted: Wed Apr 05, 2017 10:16 am  (#4) 
Offline
GimpChat Member

Joined: Mar 04, 2011
Posts: 2414
I must be doing something wrong then, since I have not seen that problem.
Since David moved to cmake I use this sequence.

rich@rich-VB:~$ git clone https://github.com/dtschump/gmic.git
rich@rich-VB:~$ cd gmic
rich@rich-VB:~/gmic$ cmake CMakeLists.txt
rich@rich-VB:~/gmic$ make


What am I doing wrong?

It gives a result. The git-master has updated in the last 4 hours which might reflect your patch but same result was obtained this morning.

Will not bore the good people here with a long listing but output is attached.


Attachments:
output.txt.zip [1.31 KiB]
Downloaded 124 times

_________________
Image
Top
 Post subject: Re: gmic-gimp-gtk and gimp 2.9.5 GIMP_STOCK_RESET issue
PostPosted: Wed Apr 05, 2017 12:44 pm  (#5) 
Offline
GimpChat Member

Joined: Oct 11, 2014
Posts: 82
@rich2005

if i use
cmake CMakeLists.txt

all my 4GB ram are full, so the SWAP partition.
Something is wrong in cmake method? I don't now ...

Any problem in src,
with
make gimp_gtk

only 60% RAM is used, no swap ...


Last edited by telperion on Thu Apr 06, 2017 6:49 am, edited 1 time in total.

Top
 Post subject: Re: gmic-gimp-gtk and gimp 2.9.5 GIMP_STOCK_RESET issue
PostPosted: Thu Apr 06, 2017 1:39 am  (#6) 
Offline
GimpChat Member
User avatar

Joined: Jan 03, 2011
Posts: 1656
Thanks @telperion, that's really helpful to know.
I'll patch the source to fix this issue.


Top
 Post subject: Re: gmic-gimp-gtk and gimp 2.9.5 GIMP_STOCK_RESET issue
PostPosted: Thu Apr 06, 2017 6:44 am  (#7) 
Offline
GimpChat Member

Joined: Oct 11, 2014
Posts: 82
Ronounours wrote:
Thanks @telperion, that's really helpful to know.
I'll patch the source to fix this issue.



with today gmic git

make gimp_gtk in src (-Ofast -march=native)
with gimp 2.8.20 -> OK
with gimp 2.9.5 -> OK

Thanks to you.


Top
Post new topic Reply to topic  [ 7 posts ] 

All times are UTC - 5 hours [ DST ]


   Similar Topics   Replies 
No new posts Reset GIMP?

5

No new posts Attachment(s) Gimp Gap Curves Issue

13

No new posts Rembg install issue

2

No new posts Attachment(s) Pasting of text issue

2

No new posts Attachment(s) Seamless Pattern - Help please - Scaling issue

4



* Login  



Powered by phpBB3 © phpBB Group