It is currently Sat Jul 06, 2024 8:11 pm


All times are UTC - 5 hours [ DST ]



Post new topic Reply to topic  [ 159 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6, 7, 8  Next
Author Message
 Post subject: Re: The RGGJAN Portable
PostPosted: Sat Oct 27, 2012 1:27 pm  (#81) 
Offline
GimpChat Member

Joined: Apr 12, 2010
Posts: 5870
Onkel Hatti wrote:
Finally I did it.
I implemented this very fantastic tool to gimp-2.8.3 (from git), and made a diff-patch from the changes.
I cannot find contact to the original author Jan Ruegg, so I don't know, wheather it is allowed to provide
the patch to the community. Does somebody have a contact to him?

The foreground select tool will not go into official gimp-2.8.x - fork, there will be no new things implemented,
only in gimp-2.9.x, there will be a new tool, realized as a gegl operation (matting-global). I don't know, how to use it,
it doesn't work for me, so I decided to implement his tool in gimp-2.8.3.


From what bilbo9955 wrote

Quote:
I had emailed the author some time ago on the status of the tool. He replied that he was now too busy to put any time into it and would no longer be working on it.

He also mentioned that the main part of the tool was complete and he was looking for someone to take over finishing the GUI. That is the only part left to be completed
.

he will be glad for the patch:geek

and we will too be very happy if you may share the binary :jumpclap :jumpclap :jumpclap

_________________
My 3D Gallery on Deviantart http://photocomix2.deviantart.com/
Main gallery http://www.flickriver.com/photos/photocomix-mandala/
Mandala and simmetry http://www.flickriver.com/photos/photocomix_mandala/

Image

Mrs Wilbress


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Sun Oct 28, 2012 2:04 am  (#82) 
Offline
GimpChat Member

Joined: Feb 22, 2012
Posts: 295
Location: Germany
I emailed him, but he didn't answer yet.
As I interpret the GPL, I think it is allowed, as long as I publish the source code, too.
That would be, of course, the case.
Sharing the binary will not be easy... I can share the patch, because the forground extraction is a
tool, so it is contained in the source of gimp-2.8.exe.
For using the tool, you have to compile the main gimp-executable. It has exactly the same functionality
(also gui) of the tool in his fork gimp-2.7.4


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Sun Oct 28, 2012 9:50 am  (#83) 
Offline
GimpChat Member
User avatar

Joined: Nov 09, 2011
Posts: 726
I am anxious that you share that patch, so I can try it on GNU/Linux.
Thank you.

_________________
Image
Be patient, English is not my language.


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Sun Oct 28, 2012 2:24 pm  (#84) 
Offline
GimpChat Member

Joined: Jul 11, 2010
Posts: 349
Onkel Hatti wrote:
I emailed him, but he didn't answer yet.
As I interpret the GPL, I think it is allowed, as long as I publish the source code, too.
That would be, of course, the case.
Sharing the binary will not be easy... I can share the patch, because the forground extraction is a
tool, so it is contained in the source of gimp-2.8.exe.
For using the tool, you have to compile the main gimp-executable. It has exactly the same functionality
(also gui) of the tool in his fork gimp-2.7.4


You might be using the old version unless someone has wrote a new GUI. Here is part of what I received from Jan on July 10:

"Actually, I more or less finished the core algorithm in gegl, the new library that Gimp is using now for image manipulation stuff: http://www.gegl.org/operations.html#op_ ... ing-global

However, I really don't have the time to keep working on it. What's missing is the whole GUI part. So currently you can only use it on the command line, and not in Gimp itself...

I guess you'll just have to wait until someone does the GUI in Gimp to be really able to use it..."


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Mon Oct 29, 2012 12:27 am  (#85) 
Offline
GimpChat Member

Joined: Feb 22, 2012
Posts: 295
Location: Germany
Yes, you are right. This is the old version. I don't know, how to use the gegl version, and I'm not able to build a GUI around it. Maybe in gimp-2.9.x (2.10), the are some gegl operations implemented as filters.
I'm still waiting for Mr. Rüegg...


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Sun Nov 04, 2012 12:25 pm  (#86) 
Offline
GimpChat Member

Joined: Feb 22, 2012
Posts: 295
Location: Germany
Jan Rüegg allowed me to publish the patch, but it must be sure, that it is under the terms
of GNU Public License
So:

Matting
Copyright (C) 2011 Jan Rüegg <rggjan@gmail.com>
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
<http://www.gnu.org/licenses/>.

The patch will change the "foreground extraction tool" to the matting tool.
The original "siox" tool will be lost.
A recompile of gimp-2.8 will be necessary.


Attachments:
matting.zip [21.11 KiB]
Downloaded 133 times
Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Sun Nov 04, 2012 3:29 pm  (#87) 
Offline
GimpChat Member
User avatar

Joined: Nov 09, 2011
Posts: 726
Thanks Onkel Hatti (And Jan Rüegg)
For what GIMP version is that patch? GIMP 2.8.2 stable version?

Edit:
Oh, sorry. I had not read above. It seems that the patch is for 2.8.3 git version, right?
But git versions have continually changes. Is it still possible to apply this patch to the current version?

_________________
Image
Be patient, English is not my language.


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Sun Nov 04, 2012 7:57 pm  (#88) 
Offline
GimpChat Member
User avatar

Joined: Sep 24, 2010
Posts: 12531
I wish you can just change out the plugin with this one; I don't know how to compile GIMP. lol

:)

_________________
Lyle

Psalm 109:8

Image


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Mon Nov 05, 2012 12:01 am  (#89) 
Offline
GimpChat Member

Joined: Feb 22, 2012
Posts: 295
Location: Germany
Thats the problem. This is not a plugin. Its a tool.
And all tools (paintbrush, erazer, etc.) are in the
gimp executable code.
I ported it to the available code, but it should work with the
2.8.2 code, too.
But there is no way but recompiling the gimp executable.


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Mon Nov 05, 2012 2:42 pm  (#90) 
Offline
GimpChat Member
User avatar

Joined: Nov 09, 2011
Posts: 726
It seems that the patch has some problems with GIMP 2.8.2:
$ patch -p1 < matting.patch
patching file app/base/Makefile.am
patching file app/base/base-types.h
patching file app/base/matting.c
patching file app/base/matting.h
patching file app/core/gimpdrawable-foreground-extract.c
patching file app/core/gimpdrawable-foreground-extract.h
patching file app/tools/gimpforegroundselectoptions.c
patching file app/tools/gimpforegroundselectoptions.h
patching file app/tools/gimpforegroundselecttool.c
Hunk #4 FAILED at 182.
Hunk #5 succeeded at 244 (offset -2 lines).
Hunk #6 succeeded at 326 (offset -2 lines).
Hunk #7 succeeded at 370 (offset -2 lines).
Hunk #8 succeeded at 570 (offset -2 lines).
Hunk #9 succeeded at 585 (offset -2 lines).
Hunk #10 succeeded at 658 (offset -2 lines).
Hunk #11 succeeded at 671 (offset -2 lines).
Hunk #12 succeeded at 685 (offset -2 lines).
Hunk #13 succeeded at 755 (offset -2 lines).
Hunk #14 succeeded at 773 (offset -2 lines).
Hunk #15 succeeded at 825 (offset -2 lines).
Hunk #16 succeeded at 844 (offset -2 lines).
Hunk #17 succeeded at 852 (offset -2 lines).
1 out of 17 hunks FAILED -- saving rejects to file app/tools/gimpforegroundselecttool.c.rej
patching file app/tools/gimpforegroundselecttool.h
patching file app/tools/tools-enums.c
patching file app/tools/tools-enums.h
patching file libgimpbase/gimpbaseenums.c
patching file libgimpbase/gimpbaseenums.h
patching file po/de.po
Hunk #3 FAILED at 12760.
1 out of 5 hunks FAILED -- saving rejects to file po/de.po.rej

_________________
Image
Be patient, English is not my language.


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Fri Nov 16, 2012 12:00 pm  (#91) 
Offline
GimpChat Member

Joined: Feb 22, 2012
Posts: 295
Location: Germany
I made some more changes and tried to improve the tool.

1. for information reasons (quality info) I added a slider, that makes the result mask opaque from 30% to 100% (default: 50%)
2. I implemented the feature, that the result can be either a new layer with the extracted object (this is default), a selection (just like the siox-tool) or both. The selection gives the possibility to create a selection mask more easyly than the default.
3. I made some of the standard parameters of the alghorithm changeable. I don't know exactly, what the parameters will change, just play around a little.
Lambda has something to do with the value of confidence, that a pixel must be in or out the selection, or maybe in between.
Radius describes the radius that colors are compared, whether they are in the selection or not.
Color distance deals with the difference of colors they must have to decide, whether they are in or out the selection.
Default value for all parameters is 10.
4. I made a patch for gimp-2.8.2 I didn't compile it, but it should work.
5. I made a patch for gimp-2.8.3 (newest git-resource from 12/11/16)

In the patch for gimp-2.8.2 i added a german translation. In the patch for gimp-2.8.3 the de.po changes too often, so two days later, the patch would not work anymore, so I put the parts of the .po files in the zip, so the de.po can be changed manually.


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Fri Nov 16, 2012 12:30 pm  (#92) 
Offline
GimpChat Member

Joined: Feb 22, 2012
Posts: 295
Location: Germany
Juhuu.

It took just a few minutes to get the .png out of the .jpg
Foreground select - make the forground better, make the background better, press enter.
Make a selecion mask of the result and push up the mask a little.


Attachments:
IMG_6059.png
IMG_6059.png [ 374.16 KiB | Viewed 1595 times ]
IMG_6059.jpg
IMG_6059.jpg [ 990.65 KiB | Viewed 1595 times ]
Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Fri Nov 16, 2012 12:44 pm  (#93) 
Offline
Global Moderator
User avatar

Joined: Apr 07, 2010
Posts: 14182
That seems to have worked quite well.

_________________
Image


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Fri Nov 16, 2012 1:21 pm  (#94) 
Offline
GimpChat Member

Joined: Aug 05, 2011
Posts: 606
Location: limestone,ny
where does the patch file go
win7 64


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Fri Nov 16, 2012 1:24 pm  (#95) 
Offline
GimpChat Member

Joined: Feb 22, 2012
Posts: 295
Location: Germany
anywhere.
the patch must be invoked from the gimp - directory


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Fri Nov 16, 2012 1:52 pm  (#96) 
Offline
GimpChat Member

Joined: Aug 05, 2011
Posts: 606
Location: limestone,ny
so i can just put it in my users/plug-ins, don't see how that's going to work, but then again i'm not the sharpest tool in the shed


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Fri Nov 16, 2012 1:55 pm  (#97) 
Offline
GimpChat Member

Joined: Feb 22, 2012
Posts: 295
Location: Germany
Oh no... It is a patch for the source code of gimp...
It changes the source and you have to recompile gimp.
The problem is, that the program isn't a plugin, but it is a tool and all the stuff concerning tools
is in the gimp-2.8.exe, so it has to be compiled.


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Fri Nov 16, 2012 5:14 pm  (#98) 
Offline
GimpChat Member
User avatar

Joined: Nov 09, 2011
Posts: 726
Onkel Hatti, Thank you very much! I applied the patch to the today git version.
Well, I've tried with a picture where the foreground is very hard to extract. The result is very good. I have only changed the "Start Percentage" value. I have used a value of 20. I had to be applying corrections painting unselected areas about 5 times:
ImageImage
Now if I copy the original layer, invert colors on the copied layer and I work on that layer, I achieved a similar result in less time:
ImageImage
The result is good considering the difficult of the picture I've chosen.
Then I will experiment with the other parameters that I have no idea what they are for :)

_________________
Image
Be patient, English is not my language.


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Fri Nov 16, 2012 5:25 pm  (#99) 
Offline
GimpChat Member
User avatar

Joined: Sep 24, 2010
Posts: 12531
I'm still hoping someone uses your updates and make a portable version of GIMP using it Onkel. I will then un-install my current RGGJAN portable (GIMP 2.7x) and replace it with yours. :)

_________________
Lyle

Psalm 109:8

Image


Top
 Post subject: Re: The RGGJAN Portable
PostPosted: Sat Nov 17, 2012 12:34 am  (#100) 
Offline
GimpChat Member

Joined: Feb 22, 2012
Posts: 295
Location: Germany
Why a portable version?
Whats wrong with the normal one?

Hatti


Top
Post new topic Reply to topic  [ 159 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6, 7, 8  Next

All times are UTC - 5 hours [ DST ]


   Similar Topics   Replies 
No new posts Attachment(s) GIMP Portable

11

No new posts Attachment(s) Samj released portable Gimp 2.10.18

2

No new posts Attachment(s) Samj has released 2.10.21 v2 portable for windows

1

No new posts Attachment(s) GIMP Portable and File Associations

2

No new posts WMF plug-in pour Gimp 2.10.13 - 2.10.12 Portable

2



* Login  



Powered by phpBB3 © phpBB Group