It is currently Thu Jul 04, 2024 2:01 am


All times are UTC - 5 hours [ DST ]



Post new topic Reply to topic  [ 130 posts ]  Go to page Previous  1, 2, 3, 4, 5 ... 7  Next
Author Message
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Mon Mar 23, 2020 11:09 am  (#21) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14816
Location: roma, italy
Removed the previous one.
Installed and run the new version.
It seems the error is still the same:

Attachment:
Cattura.PNG
Cattura.PNG [ 1.02 MiB | Viewed 1386 times ]

_________________
"Where am I ?"


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Mon Mar 23, 2020 11:35 am  (#22) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14816
Location: roma, italy
very likely the "edit_cut" a few statements above has removed the layer

Attachment:
CatturaCut.PNG
CatturaCut.PNG [ 23.01 KiB | Viewed 1382 times ]


if there is no selection the specified drawable is removed

_________________
"Where am I ?"


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Mon Mar 23, 2020 11:37 am  (#23) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2260
Location: Poland
Thanks for the test.
I will keep looking (the strangest thing is that i have no mistakes :gaah )

_________________
Image

Slava
Ukraini!


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Mon Mar 23, 2020 11:39 am  (#24) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14816
Location: roma, italy
maybe you can execute the edit_cut ONLY if there is a selection

_________________
"Where am I ?"


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Mon Mar 23, 2020 12:32 pm  (#25) 
Offline
GimpChat Member

Joined: Jun 16, 2016
Posts: 137
Hello MareroQ,
I tested the download and the error is gone.

In this way again a big thank you from Germany !!!!!

Best regards, Hardy


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Mon Mar 23, 2020 11:22 pm  (#26) 
Offline
GimpChat Member

Joined: Aug 26, 2019
Posts: 49
thank you MareroQ
Will try these out shortly.
I have Brian's Fan Illusion working on Gimp 2.10.12 Windows 10 64 bit
Brian if you are watching, Fan Illusion is one of my favourites.


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Tue Mar 24, 2020 2:06 am  (#27) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14816
Location: roma, italy
@Mareroq
Info on my tests.
Back to Spider Paint.
I added in many places this couple of statements:
isempty=pdb.gimp_selection_is_empty(newImage) #dn
if isempty==False: #dn

and I finally got the outcome.
Here it is:
Attachment:
successful.jpg
successful.jpg [ 1.42 MiB | Viewed 1345 times ]

I do not post my version because this was a quick and dirty solution.
The basic problem in that filter is that Brian makes an extensive use of the Gimp instruction pdb.gimp_edit_cut
assuming the selection is there, but if for instance the filter did select color black and there are no color black areas in the layer, then Gimp removes the whole layer.
This suggests also why you do not get that error: it depends on the image used.
Hence I attach here the image I used for the test:
Attachment:
fantasy-3132293_1920.jpg
fantasy-3132293_1920.jpg [ 809.3 KiB | Viewed 1345 times ]


If you want to release an update to that filter, you need to spend a lot of time to check any situation where the edit cut is used without check: very annoying...

_________________
"Where am I ?"


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Tue Mar 24, 2020 4:07 am  (#28) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2260
Location: Poland
Hi Diego.

Thank You very much for the expert explanation of the problem.
A lot depends on the type of image.
For 100% certainty please confirm the instructions (only without 1px can I repeat the error):

You must use an image with alpha and transparency. Even if the
transparency is a 1 pixel eraser in a corner.

_________________
Image

Slava
Ukraini!


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Tue Mar 24, 2020 4:15 am  (#29) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2260
Location: Poland
Hi P1937.
If you can post here Your version (preferably according to the scheme how as at the beginning of the thread),
Thanks.

_________________
Image

Slava
Ukraini!


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Tue Mar 24, 2020 5:15 am  (#30) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14816
Location: roma, italy
MareroQ wrote:
Hi Diego.

Thank You very much for the expert explanation of the problem.
A lot depends on the type of image.
For 100% certainty please confirm the instructions (only without 1px can I repeat the error):

You must use an image with alpha and transparency. Even if the
transparency is a 1 pixel eraser in a corner.

I confirm.
But let me say: these pre-conditions decided by Brian are a bit...ridiculous.
Better to add at the very beginning of the filter:
- pdb.gimp_layer_add_alpha....
- and an erase of -as you says- just pixel 1,1

_________________
"Where am I ?"


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Tue Mar 24, 2020 5:55 am  (#31) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2260
Location: Poland
I understand that after adding 1px the error does not occur.
Can you do it as an alternative version?

_________________
Image

Slava
Ukraini!


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Tue Mar 24, 2020 6:45 am  (#32) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14816
Location: roma, italy
Here is my "quick and dirty" modified version, which accepts RGB* input images and erases pixel 1,1 for safety.
It's suffixed with an M.
Attachment:
BA_SpiderPaintM.7z [9.21 KiB]
Downloaded 108 times

_________________
"Where am I ?"


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Tue Mar 24, 2020 7:27 am  (#33) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2260
Location: Poland
Thanks Diego - works as agreed. :paint


Attachments:
Style_udnie_test.png
Style_udnie_test.png [ 2.72 MiB | Viewed 1360 times ]

_________________
Image

Slava
Ukraini!
Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Tue Mar 24, 2020 7:59 am  (#34) 
Offline
GimpChat Member
User avatar

Joined: Oct 10, 2018
Posts: 181
Location: Charlottesville Virginia
"Quick and dirty" spider-painted wasp. Windows 10 GIMP 2.10.14. Thanks to all for all the work!

Attachment:
Wasp Spider Paint.jpg
Wasp Spider Paint.jpg [ 523.97 KiB | Viewed 1352 times ]


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Tue Mar 24, 2020 7:26 pm  (#35) 
Offline
GimpChat Member

Joined: May 12, 2015
Posts: 4694
Thank you, MareroQ for all your work and efforts to adjust these filters to 2.10. And also to Dinasset for your added effort and knowledge. The work done by both of you is greatly appreciated!


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Tue Mar 24, 2020 10:44 pm  (#36) 
Offline
GimpChat Member

Joined: Aug 26, 2019
Posts: 49
Attachment:
Fan Illusion.JPG
Fan Illusion.JPG [ 82.07 KiB | Viewed 1327 times ]
Hello MareroQ
Reference your post #29
Here is the Window which appears when I use BA Fan Illusion.


Attachments:
BA Fan Illusion.zip [7.88 KiB]
Downloaded 99 times
Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Thu Mar 26, 2020 12:04 pm  (#37) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2260
Location: Poland
Hi P1937.

Thanks for adding. Where are Your examples?

_________________
Image

Slava
Ukraini!


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Thu Mar 26, 2020 7:26 pm  (#38) 
Offline
GimpChat Member
User avatar

Joined: Jul 06, 2013
Posts: 2607
Location: California
The error I get when running BA Fan Illusion is this:
Image


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Thu Mar 26, 2020 9:02 pm  (#39) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2260
Location: Poland
I am sorry but I was waiting for the first to report it. :gaah

For Windows, the code must start with: :geek

#!/usr/bin/env python
# -*- coding: utf-8 -*-


Mackenzieh - can you add this 2 lines it and confirm the solution to the problem? :yes

_________________
Image

Slava
Ukraini!


Top
 Post subject: Re: Brian plugins for Gimp-2.10
PostPosted: Thu Mar 26, 2020 9:29 pm  (#40) 
Offline
GimpChat Member
User avatar

Joined: Jul 06, 2013
Posts: 2607
Location: California
MareroQ wrote:
I am sorry but I was waiting for the first to report it. :gaah

For Windows, the code must start with: :geek

#!/usr/bin/env python
# -*- coding: utf-8 -*-


Mackenzieh - can you add this 2 lines it and confirm the solution to the problem? :yes


I added the code to the beginning of the code in notepad and I received this error:
Image


Top
Post new topic Reply to topic  [ 130 posts ]  Go to page Previous  1, 2, 3, 4, 5 ... 7  Next

All times are UTC - 5 hours [ DST ]


   Similar Topics   Replies 
No new posts Where is Brian?

6

No new posts Attachment(s) Revival of Brian's filters

1

No new posts Attachment(s) Brian Anderson BA Novella BA Edgey BA Exaggeration V2 A

9

No new posts Attachment(s) Plugins don't work

2

No new posts Having trouble with plugins

2



* Login  



Powered by phpBB3 © phpBB Group