GIMP Chat
http://gimpchat.com/

Brian plugins for Gimp-2.10
http://gimpchat.com/viewtopic.php?f=9&t=18138
Page 2 of 7

Author:  dinasset [ Mon Mar 23, 2020 11:09 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

Removed the previous one.
Installed and run the new version.
It seems the error is still the same:

Attachment:
Cattura.PNG
Cattura.PNG [ 1.02 MiB | Viewed 1406 times ]

Author:  dinasset [ Mon Mar 23, 2020 11:35 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

very likely the "edit_cut" a few statements above has removed the layer

Attachment:
CatturaCut.PNG
CatturaCut.PNG [ 23.01 KiB | Viewed 1402 times ]


if there is no selection the specified drawable is removed

Author:  MareroQ [ Mon Mar 23, 2020 11:37 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

Thanks for the test.
I will keep looking (the strangest thing is that i have no mistakes :gaah )

Author:  dinasset [ Mon Mar 23, 2020 11:39 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

maybe you can execute the edit_cut ONLY if there is a selection

Author:  hardy111 [ Mon Mar 23, 2020 12:32 pm ]
Post subject:  Re: Brian plugins for Gimp-2.10

Hello MareroQ,
I tested the download and the error is gone.

In this way again a big thank you from Germany !!!!!

Best regards, Hardy

Author:  P1937 [ Mon Mar 23, 2020 11:22 pm ]
Post subject:  Re: Brian plugins for Gimp-2.10

thank you MareroQ
Will try these out shortly.
I have Brian's Fan Illusion working on Gimp 2.10.12 Windows 10 64 bit
Brian if you are watching, Fan Illusion is one of my favourites.

Author:  dinasset [ Tue Mar 24, 2020 2:06 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

@Mareroq
Info on my tests.
Back to Spider Paint.
I added in many places this couple of statements:
isempty=pdb.gimp_selection_is_empty(newImage) #dn
if isempty==False: #dn

and I finally got the outcome.
Here it is:
Attachment:
successful.jpg
successful.jpg [ 1.42 MiB | Viewed 1365 times ]

I do not post my version because this was a quick and dirty solution.
The basic problem in that filter is that Brian makes an extensive use of the Gimp instruction pdb.gimp_edit_cut
assuming the selection is there, but if for instance the filter did select color black and there are no color black areas in the layer, then Gimp removes the whole layer.
This suggests also why you do not get that error: it depends on the image used.
Hence I attach here the image I used for the test:
Attachment:
fantasy-3132293_1920.jpg
fantasy-3132293_1920.jpg [ 809.3 KiB | Viewed 1365 times ]


If you want to release an update to that filter, you need to spend a lot of time to check any situation where the edit cut is used without check: very annoying...

Author:  MareroQ [ Tue Mar 24, 2020 4:07 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

Hi Diego.

Thank You very much for the expert explanation of the problem.
A lot depends on the type of image.
For 100% certainty please confirm the instructions (only without 1px can I repeat the error):

You must use an image with alpha and transparency. Even if the
transparency is a 1 pixel eraser in a corner.

Author:  MareroQ [ Tue Mar 24, 2020 4:15 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

Hi P1937.
If you can post here Your version (preferably according to the scheme how as at the beginning of the thread),
Thanks.

Author:  dinasset [ Tue Mar 24, 2020 5:15 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

MareroQ wrote:
Hi Diego.

Thank You very much for the expert explanation of the problem.
A lot depends on the type of image.
For 100% certainty please confirm the instructions (only without 1px can I repeat the error):

You must use an image with alpha and transparency. Even if the
transparency is a 1 pixel eraser in a corner.

I confirm.
But let me say: these pre-conditions decided by Brian are a bit...ridiculous.
Better to add at the very beginning of the filter:
- pdb.gimp_layer_add_alpha....
- and an erase of -as you says- just pixel 1,1

Author:  MareroQ [ Tue Mar 24, 2020 5:55 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

I understand that after adding 1px the error does not occur.
Can you do it as an alternative version?

Author:  dinasset [ Tue Mar 24, 2020 6:45 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

Here is my "quick and dirty" modified version, which accepts RGB* input images and erases pixel 1,1 for safety.
It's suffixed with an M.
Attachment:
BA_SpiderPaintM.7z [9.21 KiB]
Downloaded 109 times

Author:  MareroQ [ Tue Mar 24, 2020 7:27 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

Thanks Diego - works as agreed. :paint

Attachments:
Style_udnie_test.png
Style_udnie_test.png [ 2.72 MiB | Viewed 1380 times ]

Author:  neurolurker [ Tue Mar 24, 2020 7:59 am ]
Post subject:  Re: Brian plugins for Gimp-2.10

"Quick and dirty" spider-painted wasp. Windows 10 GIMP 2.10.14. Thanks to all for all the work!

Attachment:
Wasp Spider Paint.jpg
Wasp Spider Paint.jpg [ 523.97 KiB | Viewed 1372 times ]

Author:  Pat625 [ Tue Mar 24, 2020 7:26 pm ]
Post subject:  Re: Brian plugins for Gimp-2.10

Thank you, MareroQ for all your work and efforts to adjust these filters to 2.10. And also to Dinasset for your added effort and knowledge. The work done by both of you is greatly appreciated!

Author:  P1937 [ Tue Mar 24, 2020 10:44 pm ]
Post subject:  Re: Brian plugins for Gimp-2.10

Attachment:
Fan Illusion.JPG
Fan Illusion.JPG [ 82.07 KiB | Viewed 1347 times ]
Hello MareroQ
Reference your post #29
Here is the Window which appears when I use BA Fan Illusion.

Attachments:
BA Fan Illusion.zip [7.88 KiB]
Downloaded 100 times

Author:  MareroQ [ Thu Mar 26, 2020 12:04 pm ]
Post subject:  Re: Brian plugins for Gimp-2.10

Hi P1937.

Thanks for adding. Where are Your examples?

Author:  mackenzieh [ Thu Mar 26, 2020 7:26 pm ]
Post subject:  Re: Brian plugins for Gimp-2.10

The error I get when running BA Fan Illusion is this:
Image

Author:  MareroQ [ Thu Mar 26, 2020 9:02 pm ]
Post subject:  Re: Brian plugins for Gimp-2.10

I am sorry but I was waiting for the first to report it. :gaah

For Windows, the code must start with: :geek

#!/usr/bin/env python
# -*- coding: utf-8 -*-


Mackenzieh - can you add this 2 lines it and confirm the solution to the problem? :yes

Author:  mackenzieh [ Thu Mar 26, 2020 9:29 pm ]
Post subject:  Re: Brian plugins for Gimp-2.10

MareroQ wrote:
I am sorry but I was waiting for the first to report it. :gaah

For Windows, the code must start with: :geek

#!/usr/bin/env python
# -*- coding: utf-8 -*-


Mackenzieh - can you add this 2 lines it and confirm the solution to the problem? :yes


I added the code to the beginning of the code in notepad and I received this error:
Image

Page 2 of 7 All times are UTC - 5 hours [ DST ]
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
http://www.phpbb.com/