I did see the response from Mitch, which was posted 6 weeks after I initially submitted the patch, raising three issues that would keep the patch from being included in GIMP. I never responded because I was fine with the patch as it was and I really wasn't convinced these "issues" were really valid reasons not to include the patch. From my perspective, they seemed to simply be excuses not to include a patch they really didn't want to include anyway. The overall attitude toward including a scrolling feature in the script-fu was put forth in the very 1st comment.
Quote:
If a Script-Fu dialog is larger than the screen, then this may be an indication that the script is doing a lot more than what this binding is intended for.
This is something I vehemently disagree with. Also, I'm opposed to the entire notion that every dialog must be reduced to the lowest common denominator, which is part of the GNOME guidelines, the same nonsense that gave is the disastrous and ridiculous GNOME3 interface. Another reason I never responded is that I have no desire to argue or defend my choices and if I actually spoke my mind, which I'm inclined to do, it probably wouldn't help matters.
Now that I have had my rant, let me address each concern individually.
1) the magic numbers don't work because of themesThe fact of the matter is that the original script-fu interface is broken, based on screen resolution, not to mention how it interacts with various flavors of Windows. My patch currently fixes all of these issues by allowing the user to grab the corners and resize the dialog, no matter what theme they are using or what OS they are using. If there is a clean way to dynamically calculate the "magic numbers", so as to fit perfectly on the screen with all possible GIMP themes, OS themes and OS versions, then that would be great. I very much doubt that's the case though. In my opinion, the patch is preferable to the status quo, which is a broken dialog.
3) there probably should be no scrolling at all if all widgets fit the screenScroll bars will not be presented when there is room on the screen for the dialog. In Windows 7, it's possible that the very lower section of the dialog will be hidden behind the translucent task bar at the bottom (assuming the user hasn't moved the bar to the side, which is a possibility). This issue is already fixed by the patch because the user can simply grab the edges and resize the dialog manually. If Mitch is suggesting that the user should not be able to manually resize the dialog in this case, then I don't think he's tested it on Windows or has thought it through completely. The advantage of being able to manually resize the dialog, in all cases, is apparent.
2) the table must not grow when the dialog is resizedPersonally, I'm fine with this behavior and actually, there is no point in manually increasing the size of the dialog if it fits on the screen so I'm not sure what the big issue here is, anyway. Of the three concerns, if this is the one that prevents the patch from being included in future GIMP versions, I have no problem with modifying the code to keep the widgets from growing when the dialog is manually sized upward.
saulgoode wrote:
The second item has to do with things like color swatches being scaled larger when the dialog is resized. I played around with the code to change this during the summer but did not discover the right approach.
I did the same and did not discover why these widgets got stretched out. All of the flags looked correct to me and I believe I tried all flag combinations with the same results. It might have to do with the way viewports are being used. Perhaps those more familiar with GTK+ implementation can shed some light on this behavior.