It is currently Fri Jun 28, 2024 7:09 pm


All times are UTC - 5 hours [ DST ]



Post new topic Reply to topic  [ 8 posts ] 
Author Message
 Post subject: Lighting Effects - Big Preview for Gimp-2.10.20
PostPosted: Fri Jul 17, 2020 2:34 am  (#1) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2260
Location: Poland
Although there is some bug in the Lighting Effects code:
The Filter "Lighting Effects" crashes when I use a channel as Bumpmap
https://gitlab.gnome.org/GNOME/gimp/-/issues/5305
I provide a version with a larger preview.

My solution (before compilation):
In file lighting-preview.h (line 20-21)

replace:

#define PREVIEW_WIDTH  200
#define PREVIEW_HEIGHT 200


to:

#define PREVIEW_WIDTH  550
#define PREVIEW_HEIGHT 550


As Migf1 (viewtopic.php?f=9&t=18552#p253325) rightly pointed out in Gimpressionist, the preview distorts the aspect ratio of the original due to the use of only one parameter (PREVIEWSIZE) in the original code - here are two: PREVIEW_WIDTH, PREVIEW_HEIGHT - and this problem does not occur.

Example:
http://www.home.unix-ag.org/simon/gimp/golden.html


Attachments:
Lighting Effects preview comparison.png
Lighting Effects preview comparison.png [ 126.63 KiB | Viewed 4687 times ]
Lighting Effects- Big Preview - Ubuntu 20.04_64bit.zip [122.75 KiB]
Downloaded 175 times
Lighting Effects - Big Preview-Windows_64bit.zip [134.59 KiB]
Downloaded 243 times

_________________
Image

Slava
Ukraini!
Share on Facebook Share on Twitter Share on Orkut Share on Digg Share on MySpace Share on Delicious Share on Technorati
Top
 Post subject: Re: Lighting Effects - Big Preview for Gimp-2.10.20
PostPosted: Fri Jul 17, 2020 3:00 am  (#2) 
Offline
GimpChat Member
User avatar

Joined: Sep 27, 2016
Posts: 345
Location: Germany, BW
Thank you!
Works perfectly ... Linux Mint 19.2 - GIMP 2.10.20 flatpak

_________________
Regards
nelo

(Gimp 2.10 on Linux Mint MATE 20.1)


Top
 Post subject: Re: Lighting Effects - Big Preview for Gimp-2.10.20
PostPosted: Fri Jul 17, 2020 4:16 am  (#3) 
Offline
GimpChat Member
User avatar

Joined: May 10, 2013
Posts: 1389
Location: FInland
Thank you MareroQ!
Tested on Win10 Gimp 2.10.20, works perfectly. Trying later on Linux.

Attachment:
Lighting-Effects-Big-Window-Win10.png
Lighting-Effects-Big-Window-Win10.png [ 421.51 KiB | Viewed 4652 times ]


Attachment:
Voronoi-Lighting-Bumpmap-Freefoto-1021.png
Voronoi-Lighting-Bumpmap-Freefoto-1021.png [ 535.88 KiB | Viewed 4652 times ]


Top
 Post subject: Re: Lighting Effects - Big Preview for Gimp-2.10.20
PostPosted: Fri Jul 17, 2020 2:26 pm  (#4) 
Offline
GimpChat Member
User avatar

Joined: Jul 06, 2013
Posts: 2607
Location: California
I'm not sure I understand. What part of the Lighting Effects plugin crashes? I use Windows 10 64 bit and it works fine for me.


Top
 Post subject: Re: Lighting Effects - Big Preview for Gimp-2.10.20
PostPosted: Fri Jul 17, 2020 10:44 pm  (#5) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2260
Location: Poland
Hi Mackenzieh.

This is a complicated problem, so let the Gimp developers try to solve it.
Have you tried to follow the bug reproduction steps (listed in Issues # 5305) - for me also in step 12 Lighting Effects crashes.
Also in the Samj version for Gimp-2.10.20 - in the comments - a bug has been reported using bump maps for Lighting.
I suspect is that two parameters in the bump-map have changed - but these new parameters have not been adjusted in Lighting Effects (by analogy - because this change "broke" some plugins and scripts that use parameters bump-map: waterlevel and ambient > 1).
Apart from this problem, Lighting Effects works well.


Attachments:
Old-New Bump Map.png
Old-New Bump Map.png [ 35.22 KiB | Viewed 4551 times ]

_________________
Image

Slava
Ukraini!
Top
 Post subject: Re: Lighting Effects - Big Preview for Gimp-2.10.20
PostPosted: Sat Jul 18, 2020 12:26 am  (#6) 
Offline
GimpChat Member
User avatar

Joined: Jul 06, 2013
Posts: 2607
Location: California
MareroQ wrote:
Hi Mackenzieh.

This is a complicated problem, so let the Gimp developers try to solve it.
Have you tried to follow the bug reproduction steps (listed in Issues # 5305) - for me also in step 12 Lighting Effects crashes.
Also in the Samj version for Gimp-2.10.20 - in the comments - a bug has been reported using bump maps for Lighting.
I suspect is that two parameters in the bump-map have changed - but these new parameters have not been adjusted in Lighting Effects (by analogy - because this change "broke" some plugins and scripts that use parameters bump-map: waterlevel and ambient > 1).
Apart from this problem, Lighting Effects works well.


No, I haven't tried reproducing the steps but I have it book marked, so that I can try it later.


Top
 Post subject: Re: Lighting Effects - Big Preview for Gimp-2.10.20
PostPosted: Wed Jul 22, 2020 7:46 pm  (#7) 
Offline
GimpChat Member
User avatar

Joined: Oct 10, 2018
Posts: 181
Location: Charlottesville Virginia
Just a note in case anyone else may have this issue. [No, Neuronoob, just you ...]

GIMP 2.10.20 on Windows 10 64-bit. Downloaded the Big Preview version of Lighting Effects [485 kB]. Found the older version [106 kB] where I expected it: in my Windows user plug-ins folder, where I keep separately downloaded plug-ins. Replaced the old version with the new one. The new plug-in worked the same as the old one, but there was no enlarged preview.

Tried-this-tried-that long story short: I found in the GIMP2 LIB GIMP 2.0 PLUG-INS folder another "Lighting" folder with another version of the plug-in [189 kB and dated June 10, 2020]. I assume it came with the recent GIMP .20 update. THIS was the version I had been using, not the one in my user folder.

When I replaced the old LIB version with the new version, everything, including the preview, worked fine.

But I assume the BIG PREVIEW version will/may be routinely replaced in the next GIMP update.


Top
 Post subject: Re: Lighting Effects - Big Preview for Gimp-2.10.20
PostPosted: Thu Jul 23, 2020 4:00 am  (#8) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2260
Location: Poland
Hi Neurolurker.

Thank you for your additional comments - this it can always be useful.

_________________
Image

Slava
Ukraini!


Top
Post new topic Reply to topic  [ 8 posts ] 

All times are UTC - 5 hours [ DST ]


   Similar Topics   Replies 
No new posts Attachment(s) Gimp Filter Light and Shadow Lighting Effects

42

No new posts Attachment(s) Update to Custom Font Lighting Effects GT Style to Version 0.05 Tabbed

1

No new posts use in python of plug-in lighting

4

No new posts Attachment(s) Salvaging color and lighting

17

No new posts Attachment(s) GEGL Double Glow Duel Lighting -- An Advance Filter

5



* Login  



Powered by phpBB3 © phpBB Group