It is currently Wed Jul 24, 2024 10:32 am


All times are UTC - 5 hours [ DST ]



Post new topic Reply to topic  [ 33 posts ]  Go to page Previous  1, 2
Author Message
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Thu Feb 06, 2014 6:15 pm  (#21) 
Offline
Global Moderator
User avatar

Joined: Apr 07, 2010
Posts: 14182
:ninja by wallace grrrr
Just did it 10 times, 5 times with each sphere

_________________
Image


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Thu Feb 06, 2014 6:17 pm  (#22) 
Offline
GimpChat Founder
User avatar

Joined: May 22, 2008
Posts: 5242
Location: Gimpville
@Wallace - That error appears to be GIMP 2.8.4 gradient select bug we discussed in the other thread. You're gonna have to update to 2.8.6 (or higher) to fix that. Might as well go with 2.8.10.

@Molly - In which script? What happened? Any errors?

_________________
“If you reach for the stars, you just might land on a decently sized hill.” - Stuart Hill


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Thu Feb 06, 2014 6:29 pm  (#23) 
Offline
Global Moderator
User avatar

Joined: Apr 07, 2010
Posts: 14182
Bevel reflect, no errors

_________________
Image


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Fri Feb 07, 2014 10:14 am  (#24) 
Offline
Script Coder
User avatar

Joined: Apr 23, 2010
Posts: 1553
Location: not from Guildford after all
GnuTux wrote:
Thanks for the suggestion, saulgoode.

I'm going to try setting the default string to null or to an existing path/filename and see what happens. I believe the other script I tested it on did have a default path and filename, but when you hit the reset button, it didn't get reset back to that path. It got reset back to "null (none) and I got the same error message, but with with a garbled path.

Actually, the default does not get set back to the filename specified in your script-fu-register function, it gets sets to "(None)" -- whereas your specified filename is "none". Maybe this is what you meant but I think it is necessary to be clear on this (perhaps change test.scm to use a more distinct filename).

It is still unclear to me exactly what is going on, but I suspect the offending code appears in script-fu-interface.c. The documentation for GtkFileChooser states that gtk_file_chooser_set_filename() should not be used for non-existent files (instead gtk_file_chooser_set_current_name() should be used). However, the SF-FILENAME specification of Script-fu's script-fu-register procedure does not protect against specifying non-existent files, and I see no special handling for this case.

_________________
Any sufficiently primitive technology is indistinguishable from a rock.


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Fri Feb 07, 2014 11:15 am  (#25) 
Offline
GimpChat Founder
User avatar

Joined: May 22, 2008
Posts: 5242
Location: Gimpville
saulgoode,

When I set the path/filename to null (empty string)
SF-FILENAME _"Select File" ""

It defaults to my home folder /home/gnutux
When I hit reset, it changes to "(none)".

The same thing occurrs when I set it to the following: "beavis.jpg".

SF-FILENAME _"Select File" (string-append gimp-data-directory "/scripts/images/beavis.jpg")
After a reset, it reverts to "(none)".

It seems to me, the proper behavior for a reset would be to set it back to what is specified in SF-FILENAME.

The strange thing is, the error I'm seeing gets generated only when both SF-FILENAME & SF-GRADIENT are in the script (and I click reset). At least for me, that's seems to be the case. I'll attempt to trace though the module you pointed out and look for anything odd. When the reset is clicked, maybe something is being left undefined?

Btw - I do have the latest devel version of GIMP (cloned GIT from a couple of weeks ago) but *I haven't tested this issue on that version yet. I've setup my system to allow me to run 2.8.10 and the latest devel version, side by side, so I can compile any test changes we make and it will not affect the production version of GIMP provided in my distro's repos.

*Tested in the devel version and get the same "String Read" error. Tested the EnviroLogo script on the GIMP devel version, which has both dialogs, and it worked several times. It did finally quit working after several resets and generated the following error at stdout: "EEEEeEeek! 15 GeglBuffers leaked"

I don't know is that Gegl error is related but I thought I'd mention it, nonetheless

_________________
“If you reach for the stars, you just might land on a decently sized hill.” - Stuart Hill


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Fri Feb 07, 2014 11:48 am  (#26) 
Offline
GimpChat Founder
User avatar

Joined: May 22, 2008
Posts: 5242
Location: Gimpville
saulgoode wrote:
Actually, the default does not get set back to the filename specified in your script-fu-register function, it gets sets to "(None)" -- whereas your specified filename is "none". Maybe this is what you meant but I think it is necessary to be clear on this (perhaps change test.scm to use a more distinct filename).

Just to clarify on the "(none)" issue. If I set it to anything other than null "" or a valid path/filename, it appears as "(none)" in the Script-Fu Select File browse dialog, which is what it reverts to when the Reset button is clicked. That tells us it's not being reset to null, and it's not being reset to a valid path/filename. It actually suggests that it's undefined, after a Reset. The fact that it shows up as "(none)" after a Reset, means that it could be set to anything (other than null or a valid path/filename).

_________________
“If you reach for the stars, you just might land on a decently sized hill.” - Stuart Hill


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Fri Feb 07, 2014 1:08 pm  (#27) 
Offline
GimpChat Member

Joined: Dec 27, 2012
Posts: 393
Location: England
Image

I tried this again and after running the test filter on a jpeg image for about four or five times the error message started appearing. Hope this helps.

_________________
Image

DeviantArt gallery


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Fri Feb 07, 2014 1:20 pm  (#28) 
Offline
GimpChat Founder
User avatar

Joined: May 22, 2008
Posts: 5242
Location: Gimpville
Thank you, Caz, for confirming that I'm not crazy and the problem isn't limited to my machine. :hehe

On my box, if I run the test script, click the reset multiple times, then click OK, I get the error every time.

Molly is running Fedora but she cannot duplicate this error. She is running Gnome 3. What you and I have in common, I believe, is that we are both running the MATE desktop. Is that correct?

So far, we have 2 confirmed Linux machines that see this problem, one is Mint 16 (Ubuntu derivative) and the other is Fedora 20 (does it in Fedora 18 too). No Windows boxes, yet..

_________________
“If you reach for the stars, you just might land on a decently sized hill.” - Stuart Hill


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Fri Feb 07, 2014 4:48 pm  (#29) 
Offline
Script Coder
User avatar

Joined: Apr 23, 2010
Posts: 1553
Location: not from Guildford after all
GnuTux wrote:
*Tested in the devel version and get the same "String Read" error. Tested the EnviroLogo script on the GIMP devel version, which has both dialogs, and it worked several times. It did finally quit working after several resets and generated the following error at stdout: "EEEEeEeek! 15 GeglBuffers leaked"

I don't know is that Gegl error is related but I thought I'd mention it, nonetheless

I inserted some kludge code to display the filename in the progress bar (and pause for a few seconds to offer time to read it).
(gimp-progress-update 0)
(gimp-progress-set-text filename)
(let loop ((t (+ (realtime) 5)))
  (if (< (realtime) t)
    (loop t)))

This code only executes if the error is not raised (of course), however, I noticed that when it was executed, the filename was erroneous: "/home/saul/home/saul". Such erroneous filenames might be the cause of your GEGL buffer errors (depending upon what the script is attempting to do with the filename).

Attachment:
File comment: Screenshot of test.scm dialog.
SS-sf-filename-bug.png
SS-sf-filename-bug.png [ 4.66 KiB | Viewed 1218 times ]

_________________
Any sufficiently primitive technology is indistinguishable from a rock.


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Fri Feb 07, 2014 9:16 pm  (#30) 
Offline
GimpChat Founder
User avatar

Joined: May 22, 2008
Posts: 5242
Location: Gimpville
Good idea to display that filename. :hehe

The same thing happens on my machine. I'm thinking that on reset, the intent is to set the filename to be the home folder (or null), but for some reason, it's being concatenated with itself. In lieu of it being "reset" to whatever is specified in SF-FILENAME, if it were set to the home folder (or null), everything should be OK, wouldn't you think?

When I set the filename "" to an empty string (null) in Scheme, it displays the home folder. Perhaps on reset, somewhere in GIMP the filename is set to null (which makes it the home folder), then it appends the home folder again, thinking it's being appended to an empty string. That's how it gets doubled. I dunno. It's just a theory, based on what I've seen so far.

Do you think it's worth changing gtk_file_chooser_set_filename() to gtk_file_chooser_set_current_name() to test what happens?

I was under the impression that hitting the reset was the same as "refreshing scripts", except it was just being applied to the current script. Obviously, that's not the case. I guess the code that's executed when a reset occurs needs to be traced to find out what's going on.

Btw - I installed Fedora 20 Gnome3 in a VM and got the same errors there too, so it's not a GTK3 DE issue.

_________________
“If you reach for the stars, you just might land on a decently sized hill.” - Stuart Hill


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Sat Feb 08, 2014 6:31 am  (#31) 
Offline
GimpChat Member

Joined: Dec 27, 2012
Posts: 393
Location: England
GnuTux wrote:
Molly is running Fedora but she cannot duplicate this error. She is running Gnome 3. What you and I have in common, I believe, is that we are both running the MATE desktop. Is that correct?

So far, we have 2 confirmed Linux machines that see this problem, one is Mint 16 (Ubuntu derivative) and the other is Fedora 20 (does it in Fedora 18 too). No Windows boxes, yet..


Yeah, I'm running the mate desktop.

_________________
Image

DeviantArt gallery


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Sat Feb 08, 2014 7:04 am  (#32) 
Offline
Script Coder
User avatar

Joined: Apr 23, 2010
Posts: 1553
Location: not from Guildford after all
GnuTux wrote:
Do you think it's worth changing gtk_file_chooser_set_filename() to gtk_file_chooser_set_current_name() to test what happens?

I think that testing whether the file exists and choosing the appropriate one of those two functions would be worthwhile pursuing. I chatted with Kevin Cozens on IRC and he will hopefully get a chance to look into this; so I'm going to wait a few days and see what he comes up with (but you may want to pursue a solution on your own, which is fine).

_________________
Any sufficiently primitive technology is indistinguishable from a rock.


Top
 Post subject: Re: Another GIMP 2.8.x Gradient Related Error (Bug?) Need Help Testing
PostPosted: Sat Feb 08, 2014 12:40 pm  (#33) 
Offline
GimpChat Founder
User avatar

Joined: May 22, 2008
Posts: 5242
Location: Gimpville
Sounds good, saul. Thanks for all your help in running this one down.

Perhaps I will pursue this further on my own, if for no other reason than to learn something new. ;)

_________________
“If you reach for the stars, you just might land on a decently sized hill.” - Stuart Hill


Top
Post new topic Reply to topic  [ 33 posts ]  Go to page Previous  1, 2

All times are UTC - 5 hours [ DST ]


   Similar Topics   Replies 
This topic is locked, you cannot edit posts or make further replies. Images related to politics and religion

15

No new posts Attachment(s) Amazing what can be found under testing

30

No new posts Testing Gmic-Qt Standalone 3.1

4

No new posts Attachment(s) questions about testing with DIEGO_Render_FillingPlus

13

No new posts Attachment(s) New layer modes in LayerFX-2.10 for testing.

9



* Login  



Powered by phpBB3 © phpBB Group