It is currently Wed Aug 19, 2026 2:47 am


All times are UTC - 5 hours [ DST ]



Post new topic Reply to topic  [ 24 posts ]  Go to page Previous  1, 2
Author Message
 Post subject: Re: Files deleted?
PostPosted: Mon May 27, 2013 4:11 am  (#21) 
Offline
GimpChat Member

Joined: May 09, 2012
Posts: 914
@Ronounours

Here is an example of regression in 1552, there may be others ...

gmic 256,256,1,3 -spline 127,5,0,0,127,210,800,-400,1,255,0,255


Top
 Post subject: Re: Files deleted?
PostPosted: Mon May 27, 2013 5:09 am  (#22) 
Offline
GimpChat Member
User avatar

Joined: Jan 03, 2011
Posts: 1656
Command '-spline' has been recoded as a custom command in G'MIC (instead of a native one, in C++), and maybe you can consider this is a regression, but from my point of view, this is more an improvement :)
Having more and more custom commands (written in G'MIC language instead of in C++) is a great thing, as in one hand we gain in flexibility, and on the other hand we can better cope with necessary API changes if required in the future, without the need to release a new binary version. In your case, that's only the meaning of the arguments that has been changed, nothing really problematic. I would suggest always making your filters compatible with the latest stable version, as the API is converging to something more and more robust, so this means less changes to do in the future.
In your case :

gmic 256,256,1,3 -spline 127,5,0,0,127,210,800,-400,100,255,0,255

does the trick.

David.

PS : Also, almost all reasonable developers will tell you that breaking some parts of an API is good. This is not only to bother you, but to converge into something better. The code of open source projects can be seen by everyone, so probably, most of the open source developers are concerned by the 'beauty' of the code and the API, rather than keeping the backward compatibility at any price (which often means does some crappy hacks in the source code).


Top
 Post subject: Re: Files deleted?
PostPosted: Mon May 27, 2013 9:30 am  (#23) 
Offline
GimpChat Member
User avatar

Joined: Sep 22, 2012
Posts: 2089
Location: US
:tyspin David and Sam!
It's IN now!
You guys rock! :bigthup


Top
 Post subject: Re: Files deleted?
PostPosted: Mon May 27, 2013 9:46 am  (#24) 
Offline
GimpChat Member
User avatar

Joined: Jan 03, 2011
Posts: 1656
I've done as well the necessary changes to include by default all external filters for the next release.
The current beta I have display more than 170 filters even without update ;)


Top
Post new topic Reply to topic  [ 24 posts ]  Go to page Previous  1, 2

All times are UTC - 5 hours [ DST ]



* Login  



Powered by phpBB3 © phpBB Group