GIMP Version: 2.10.2
Operating System: Windows
GIMP Experience: Basic Level

List any relevant plug-ins or scripts:
gimp basic function: selection_save

List any ERROR messages you received:
selected area no more fillable after save

---

Hi.
During my experiments on gimp 2.10 I encountered this behaviour:

- have an image
- perform a selection on it
- call a filter (.py in my case)
- do inside a filter a "save selection"
- the area inside the selection is no more fillable/active

To double-check:
- download the simple test filter
- have an image with a selection
- pass across the image using the bucket fill tool: the area inside the selection is fillable, the area outside is not: correct
- run the filter with the option save=no
- the image stays as before: area inside is fillable
- now run the filter with option save=yes
- now the area inside the selection is no more fillable: ??

Could it be an error? Or is there something I missed?

Thanks.

With the selection saved I get a message in the Error Console:


The documentation for gimp-selection-save says it creates a new channel, so it appears that it leaves the new channel as the active drawable. Therefore you may need to remember which is the active layer before you save the selection and then re-activate it after saving.

Thanks a lot for your suggestion, just adding the statement
pdb.gimp_image_set_active_layer (inImage, inLayer)
after the selection_save
solved the problem.

And it has been that way for a long time (at least in 2.8...). No need for a script, "Select>Save to channel" has the same effect. This said, in a script, it shouldn't matter, the initial active drawable is passed as a parameter and this is what the script code should be using (instead of fetching the active layer again(*))

(*) also because the script could be called from another, who would want something to be done to a specific layer which isn't the active layer. Script don't act on the active layer, they act on the layer passed as a a parameter, which, when called from the UI, will usually (but not always...) be the active layer.

If a script is called with a layer having a selection to be processed by the script, and the script needs to "save the selection" (for instance, for restoring it after some operation), then the script is no more callable again with the same source drawable/selection because of the "not visible active layer" situation illustrated above.
What I mean is that the initial situation is not reset unless the additional step suggested is performed.

BTW testing the small script posted here at #1 on a gimp 2.8 what I was complaining about does not occur, the source image is always in its initial state, even after the "save selection" step, i.e. the selected area remains fillable; hence something seems to have changed in 2.10.
Can this be double-checked? Thanks.

This simplified version:

Has the same problem in 2.8. But there is a PDB function to set the active layer, to you can always restore the active layer at the end of your script.

PS: if you con't put parentheses after "gimp_context_push", it does nothing (with is all the better since there is no matching pop()...

Thanks for the double-checking, Ofnuts.
But also using your simplified filter, in my 2.8.22 the input selection area remains fillable (no problem as in 2.10.2 here).

...but today also on 2.10.2 my testing filter works (?!)

phantom effect….