Gimp-2.8.0-RC1 Tiff-Load/save

Onkel Hatti · **Posted:** Tue May 01, 2012 12:58 pm **(#1)**

OS: windows
Gimp: 2.8.0-RC1 (32Bit)

Hi All.

I debugged a little...
There seems to be a problem for libtiff-5.dll opening/saving files by file descriptor.
The gimp plugin uses this way. I don't see the needs. So I changed the plugin source
to open the file directly. And now it works with libtiff-5.dll

Hatti

Rod · **Joined:** May 16, 2010 **Posts:** 16144

Onkel you should submit these fixes to the dev team for addition to the new Gimp-2.8 official release.

I am sure they would be thankful for the patches.

Onkel Hatti · **Posted:** Tue May 01, 2012 1:30 pm **(#3)**

Hi Rod.

I did... again.
I announced a patch to change gimp from lcms1 to lcms2. I asked for review.
What I got, was an answer that my patch did not fit the coding conventions...

Rod · **Joined:** May 16, 2010 **Posts:** 16144

Onkel Hatti wrote:

Hi Rod.

I did... again.
I announced a patch to change gimp from lcms1 to lcms2. I asked for review.
What I got, was an answer that my patch did not fit the coding conventions...

As in porting everything to GEGL?

Onkel Hatti · **Posted:** Tue May 01, 2012 2:10 pm **(#5)**

Was there the same problem? I didn't her anything about.
To make the code readable, strict coding conventions are absolutely necessary.