please help me customise this script (Motif_Geometrique_3D)

Esper · **Joined:** Jul 17, 2012 **Posts:** 2769

today i cleaned my script folder, deleting various stuff that i never use

also i changed the path of my favorite scripts, so they appear at a destination i like best

did that with samj's Motif_Geometrique_3D
viewtopic.php?f=9&t=6844

originally it is under File -> Create -> Pattern
a place where i never look.....

i managed to change it, so its now under Filters -> Render -> Pattern :yes

also i changed the default colour to black, grey and white, instead of the tricolor

what i would like now, is the filter to reappear under 'Filter-> Repeat Last'

Rod gave an explanation how to do that, here:
viewtopic.php?f=8&t=7562

but i still cant do it :cry

can somebody please help me ?!

here is my customised samj script:

SHOW SPOILER

saulgoode · **Posted:** Sun Jul 14, 2013 2:08 pm **(#2)**

Replace the last section of code with the following:

Code: Select all

(script-fu-register "Motif_Geometrique_3D_samj"
  _"3D Motif Geometrique..."
  "3D pattern made of 3 colours"
  "samj"
  "samj"
  "20130403"
  ""
  SF-ADJUSTMENT "X 1 " '(16 1 128 1 5 0 1)
  SF-ADJUSTMENT "X 2 " '(16 1 128 1 5 0 1)
  SF-ADJUSTMENT "V 1 " '(16 1 64 1 5 0 1)
  SF-ADJUSTMENT "V 2 " '(16 1 64 1 5 0 1)
  SF-ADJUSTMENT "V 3 " '(16 1 64 1 5 0 1)
  SF-ADJUSTMENT "V 4 " '(16 1 64 1 5 0 1)
  SF-COLOR "Color 1 " '(255 255 255)
  SF-COLOR "Color 2 " '(128 128 128)
  SF-COLOR "Color 3 " '(0 0 0)
  SF-OPTION "Ribbon (Wmax=512px) " '("A Without" "B Ribbon small" "C Large ribbon")
  SF-TOGGLE "Save Pattern" FALSE
  SF-STRING "Pattern Name to save (DO NOT USE SPACES)" "3d_Motif_Geometrique" 
 )

(script-fu-menu-register "Motif_Geometrique_3D_samj"
  _"<Image>/Filters/Render/Pattern" )

Rod · **Joined:** May 16, 2010 **Posts:** 16013

I was going to say it was Saulgoode that fixed it not myself.

Thanks Saulgoode.

Esper · **Joined:** Jul 17, 2012 **Posts:** 2769

thanks saulgoode

but it still does not reappear under filters

Rod · **Joined:** May 16, 2010 **Posts:** 16013

Esper wrote:

thanks saulgoode

but it still does not reappear under filters

If you run it once it doesn't allow for reshow or repeat?

molly · **Joined:** Apr 07, 2010 **Posts:** 14182

It should be under Filters > Render > Pattern

Esper · **Joined:** Jul 17, 2012 **Posts:** 2769

thats correct Rod

Rod · **Joined:** May 16, 2010 **Posts:** 16013

Esper wrote:

thats correct Rod

That is odd, it should have worked changing the menu structure in the code.
Have you tried refreshing scripts or just restarting gimp at all?

Esper · **Joined:** Jul 17, 2012 **Posts:** 2769

yes, both

i attach the edited script...mybe i made a mistake....

Rod · **Joined:** May 16, 2010 **Posts:** 16013

Esper wrote:

yes, both

i attach the edited script...mybe i made a mistake....

Looks like you have it all correctly coded to me.

I thought maybe the push-undo call had something to do with it but it didn't help.
Hopefully someone will come along soon and help you out.

saulgoode · **Posted:** Sun Jul 14, 2013 4:28 pm **(#11)**

Try inserting an asterisk into the empty quotes that follow the date. GIMP apparently doesn't want to allow "repeats" of the image creation scripts.

Code: Select all

(script-fu-register "Motif_Geometrique_3D_samj"
  _"3D Motif Geometrique..."
  "3D pattern made of 3 colours"
  "samj"
  "samj"
  "20130403"
  "*"
  SF-ADJUSTMENT "X 1 " '(16 1 128 1 5 0 1)
  :
  :
  :

Esper · **Joined:** Jul 17, 2012 **Posts:** 2769

it still doesnt work

GnuTux · **Posted:** Sun Jul 14, 2013 5:19 pm **(#13)**

Unlike the other scripts located under Filter->Renders->Pattern, this script renders a complete new image, rather than working off (filling) an existing image. That being the case, there is nothing to repeat.

The script works the same as the other pattern render scripts located under Create->New->Patterns. Moving it to another menu location doesn't change the script's functionality. To allow for repeat/re-show, the script would need to be modified to work on an existing image, like the other scripts located under Filter->Renders->Pattern.

Rod · **Joined:** May 16, 2010 **Posts:** 16013

GnuTux wrote:

Unlike the other scripts located under Filter->Renders->Pattern, this script renders a complete new image, rather than working off (filling) an existing image. That being the case, there is nothing to repeat.

The script works the same as the other pattern render scripts located under Create->New->Patterns. Moving it to another menu location doesn't change the script's functionality. The script would need to be modified to work on an existing image, like the other scripts located under Filter->Renders->Pattern, to allow for repeat/re-show.

I had a feeling it may have to do with being a new image. That makes sense.

Thanks Tux.

Esper · **Joined:** Jul 17, 2012 **Posts:** 2769

GnuTux: i didnt expect the script's functionality to change
i just wanted it in a different location

saying there is nothing do repeat isnt true, because most of the time i need more than one go to find the right values
but i guess i understand what you mean

GnuTux · **Posted:** Sun Jul 14, 2013 5:33 pm **(#16)**

Well, I should have been more precise. I meant as far as GIMP is concerned, there is nothing to repeat. I understand that you need to run the script multiple times to try out various settings, in order to get the results you're after.

What you want can be done. The script doesn't have to do anything to an existing image. It just needs to be modified to follow the structure of the other scripts located under Filter->Renders->Pattern. I noticed that there are other problems with the script as well. It threw an undeclared variable (function name) error when I changed the ribbon option dropdown to B or C.

PhotoComix · **Joined:** Apr 12, 2010 **Posts:** 5870

Erisian

you may use bimp to repeat the script

PhotoComix · **Joined:** Apr 12, 2010 **Posts:** 5870

GnuTux

Quote:

I noticed that there are other problems with the script as well. It threw an undeclared variable (function name) error when I changed the ribbon option dropdown to B or C.

For that something screwed up the script formatting :

Quote:

...error when I changed the ribbon option dropdown to B or C.

With the command broken in the middle by empty lines no surprise that doesn't work :

look Here

SF-COLOR "Color 2 " '(128 128 128)
SF-COLOR "Color 3 " '(0 0 0)
SF-OPTION "Ribbon (Wmax=512px) " '("A Without" "B

Ribbon small" "C Large ribbon")
SF-TOGGLE "Save Pattern" FALSE

...

PhotoComix · **Joined:** Apr 12, 2010 **Posts:** 5870

Erisian you really risk to loose your time :

What you posted is pratically unusable as if the script was open or paste using a word editor (as MS Word )instead then a text editor (as notepad )

If you want edit it download again the script
if you want be sure to avoid similar formatting problem (even MS notepad may screw up script , seldom but may happen ) use notepad + http://notepad-plus-plus.org/download/ or similar source code editors

GnuTux · **Posted:** Sun Jul 14, 2013 6:25 pm **(#20)**

My version of the script is not broken there, PC. The script would still work, even with the line break (CRs) in that location. Although, it would make the dropdown look strange.

I'm also not noticing a lot of formatting issues like you are, just some extra white space between code sections.

I am getting this error message when selecting B or C from the dropdown:

Error: ( : 32710) eval: unbound variable: Fonction_Motif_Geometrique_1_3D_samj

Looks like some debugging is in order for this script too.