[Resolved: Buggy Programmer]Possible Bug -- Need Confirmation

jazzon · **Posted:** Mon Aug 24, 2015 12:18 pm **(#1)**

I have found a possible bug in G'MIC 1.6.5.1 which I need confirmed before I file a bug report.
If you are running:
gimp 2.8 with full python support
gmic 1.6.5.1
(preferably on Debian or a derivitive (including Ubuntu 14.04 or mint 17.1))
Please try the attached script.

Proper response should be your images active layer filled with plasma noise.

To test:
Install the attached file to your plugins folder
(make sure it's is executable)
It adds a big button to your menu bar, so delete it after test.
start gimp from the command line as:

Code: Select all

gimp --verbose

Then from gimp:
Filters->G'MIC
set output messages to Very verbose (console)
And watch for error windows.

The command line output I am getting is:

Code: Select all

RuntimeError: calling error
[gmic]-1./ Start G'MIC interpreter.
[gmic]-1./gimp_plasma/*if/ Force image [0] to be in RGB mode.
[gmic]-1./gimp_plasma/*if/ Fill image [0] with random values, in range [0,255].
[gmic]-1./gimp_plasma/ Draw plasma fractal on image [0], with alpha 1, beta 7.66 and scale 2.
[gmic]-1./gimp_plasma/ Normalize image [0] in range [0,255].
[gmic]-1./gimp_plasma/*substitute/ Input file '6-8' at position 1
[gmic]-1./gimp_plasma/*substitute/ *** Error *** Unknown filename '6-8'.
[gmic]-1./gimp_plasma/ Abort G'MIC interpreter.

But there are no file operations going on in the plug-in I wrote (which was previously working).
[EDIT: forgot the file !]

[EDIT2 I forgot to make a small change in the code. The newer gmic requires three more arguments than the first one did, the second zip corrects this.]

ofnuts · **Joined:** Oct 25, 2010 **Posts:** 4812

Independently of any GMIC bug:

Code: Select all

noiseLayer = pdb.gimp_image_get_active_drawable(inImage)

It's cleaner to do:

Code: Select all

noiseLayer = inImage.active_drawable

But normally, this very drawable is already given to you as the 'inDrawable' argument...

jazzon · **Posted:** Mon Aug 24, 2015 12:40 pm **(#3)**

LOL, leave it to you to see that!

This was my first ever plug-in, and the whole code is really really messy.
I stripped it down for this test.

jazzon · **Posted:** Mon Aug 24, 2015 12:45 pm **(#4)**

Added a second zip file to correct for a change in GMIC's code base between teh original version and the new version.

Ofnuts No I did not change the other line

Ronounours · **Joined:** Jan 03, 2011 **Posts:** 1656

You have to remove the 'spaces' in your list of arguments when calling G'MIC.
Spaces in G'MIC are item separator, so it's very important not to add them everywhere

jazzon · **Posted:** Mon Aug 24, 2015 2:09 pm **(#6)**

OK,

It turns out that it is not a bug.

For future reference of script writers, a G'MIC command string looks like this (sample for the plasma filter):

Code: Select all

"-gimp_plasma 1.0,7.66,2,1,0,128,128,128"

in python that would properly be written as:

Code: Select all

"-gimp_plasma 1.0, 7.66, 2, 1, 0, 128, 128, 128"

Which as it turns out thoroughly confuses G'MIC.
In a G'MIC command string, once you type in a value which part of the comma separated values, there can be no spaces. At all. What-so-ever. etc.

jazzon · **Posted:** Mon Aug 24, 2015 2:11 pm **(#7)**

Ronounours LOL Was already loaded to this page so I didn't see your post ahead of mine! Figured it out by accident when I rewrote teh code for the third time!

Thank you for your response though.

Ronounours · **Joined:** Jan 03, 2011 **Posts:** 1656

Yes, as I said, space in G'MIC is an item separator, so if you put it in a list of arguments, it's like you have a shorter list of argument, followed by another command.