It is currently Tue Aug 18, 2026 11:15 pm


All times are UTC - 5 hours [ DST ]



Post new topic Reply to topic  [ 204 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6, 7 ... 11  Next
Author Message
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 9:17 am  (#61) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14831
Location: roma, italy
Thanks iarga.
I hope David will agree and avoid overlaying the fave.

_________________
"Where am I ?"


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 9:25 am  (#62) 
Offline
GimpChat Member
User avatar

Joined: Jan 03, 2011
Posts: 1656
I'll ask the developer to see if this is possible.


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 9:59 am  (#63) 
Offline
GimpChat Member
User avatar

Joined: Mar 28, 2016
Posts: 312
Location: Netherlands
dinasset, please test again. I can not reproduce this anymore. Now it seems to work as I want.


Last edited by iarga on Thu Mar 09, 2017 10:01 am, edited 1 time in total.

Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 10:00 am  (#64) 
Offline
GimpChat Member
User avatar

Joined: Jan 03, 2011
Posts: 1656
Hum, that is not so simple in fact. There are two options :

1. We let the plug-in remember the latest state of each fave filter (as it does right now), which means you have to press the 'Reset' button to be sure you really get the parameters used when you added the filter to the faves.

*or*

2. The plug-in always display a fave filter with its 'default' parameters, i.e. the parameters used when the filter has been added to the faves. But in this case, I'm almost sure we'll get complaints too. Imagine a user with several images to process. He clicks on his fave filter, but this time, the parameters do not fit exactly what he wants, so he has to change for instance a single parameter (let us say he adds 0.2 to a parameter 'Smoothness' of the filter). What the preview displays seems fine, so he applies the filter on the whole image, just to be sure it's OK. -> he clicks 'OK', wait a few seconds, and is happy of the result. So now, he wants to apply the same filter on several images again, re-show the G'MIC plug-in, click on his fave filter, and... the parameters has returned to its initial state. Not sure he will be really happy about that, because he has to re-tweak his Smoothness parameter again before applying the filter to his list of images.

You may say : he can just create a new fave from his new set of parameters before leaving the plug-in (i.e. clicking OK). But as he hasn't seen the final result, it seems not intuitive to create a fave before being happy of the result.

Probably the best way of doing would be a mix between the two behaviors, including the notion of a GIMP 'session'. The parameters should be preserved during a single session, then once GIMP is closed and restarted, the fave parameters go back to their initial state.
But as the plug-in is intended to be as much GIMP-independent as possible, this makes the thing quite hard to implement from a technical point of view.


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 10:33 am  (#65) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14831
Location: roma, italy
iarga wrote:
dinasset, please test again. I can not reproduce this anymore. Now it seems to work as I want.

For me it does what it did before. You may repeat the steps I illustrated on the previous post.

_________________
"Where am I ?"


Last edited by dinasset on Thu Mar 09, 2017 10:38 am, edited 1 time in total.

Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 10:37 am  (#66) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14831
Location: roma, italy
Ronounours wrote:
Hum, that is not so simple in fact. There are two options :

1. We let the plug-in remember the latest state of each fave filter (as it does right now), which means you have to press the 'Reset' button to be sure you really get the parameters used when you added the filter to the faves.

*or*

2. The plug-in always display a fave filter with its 'default' parameters, i.e. the parameters used when the filter has been added to the faves. But in this case, I'm almost sure we'll get complaints too. Imagine a user with several images to process. He clicks on his fave filter, but this time, the parameters do not fit exactly what he wants, so he has to change for instance a single parameter (let us say he adds 0.2 to a parameter 'Smoothness' of the filter). What the preview displays seems fine, so he applies the filter on the whole image, just to be sure it's OK. -> he clicks 'OK', wait a few seconds, and is happy of the result. So now, he wants to apply the same filter on several images again, re-show the G'MIC plug-in, click on his fave filter, and... the parameters has returned to its initial state. Not sure he will be really happy about that, because he has to re-tweak his Smoothness parameter again before applying the filter to his list of images.

You may say : he can just create a new fave from his new set of parameters before leaving the plug-in (i.e. clicking OK). But as he hasn't seen the final result, it seems not intuitive to create a fave before being happy of the result.

Probably the best way of doing would be a mix between the two behaviors, including the notion of a GIMP 'session'. The parameters should be preserved during a single session, then once GIMP is closed and restarted, the fave parameters go back to their initial state.
But as the plug-in is intended to be as much GIMP-independent as possible, this makes the thing quite hard to implement from a technical point of view.

The correct solution is the last one, which you called "mix".
During a single session it's appropriate to keep the parameters, and BTW this is what Gimp does for all its filters.
At close/reopen the single saved filters should start with the stored defaults.
I don't know how other packages invoking G'MIC behave, but this seems the most clever solution.

_________________
"Where am I ?"


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 10:53 am  (#67) 
Offline
GimpChat Member
User avatar

Joined: Mar 28, 2016
Posts: 312
Location: Netherlands
Dinasset, I think I did mess up some faves with the transition to qt. That's the reason I thought something was wrong. But I see the reset to original saved fave works. For me that's the most important. I can understand that most people like the save last settings function as it is now.

I too, like it as it is now. My excuses David for misunderstanding. (happens me a lot :oops: )

Also my excuses to you dinasset. I think I misunderstood you too. :oops:


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 11:18 am  (#68) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14831
Location: roma, italy
In my case (the colour) the reset button resets it NOT to my previous saved one but to the standard filter default. Error?

_________________
"Where am I ?"


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 11:24 am  (#69) 
Offline
GimpChat Member
User avatar

Joined: Mar 28, 2016
Posts: 312
Location: Netherlands
Dinasset, try it with a new fave in QT-g'mic,

Maybe the transition to new system did some "things" :bye ?


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 11:38 am  (#70) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14831
Location: roma, italy
OK.

_________________
"Where am I ?"


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 1:20 pm  (#71) 
Offline
GimpChat Member
User avatar

Joined: Sep 24, 2010
Posts: 12832
Original g'mic would keep the changes until you either reset the plugin or reboot GIMP. As stated, if you modify a preset and it keeps, it's no longer a fav. Regardless, just wish I can figure out why the plugin still keeps asking me to import favs but indeed never does. :)

_________________
Lyle

Psalm 109:8

Image


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 2:34 pm  (#72) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14831
Location: roma, italy
Thanks Lyle, that's my opinion too.
A fav is a way to "stabilize" a set of parameters, until the user himself decide to change it permanently. A fav should not be interpreted only as a quick list of the preferred filters.
Think about filters with a lot of parameters...
This problem is certainly more "severe" for you, who uses continuously G'MIC, than for me.

_________________
"Where am I ?"


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Thu Mar 09, 2017 3:11 pm  (#73) 
Offline
GimpChat Member
User avatar

Joined: Jan 03, 2011
Posts: 1656
About the faves : this is something I need to discuss with the developer. As I said earlier, having the notion of a GIMP session for a self-contained program as G'MIC (Qt) is not particularly easy to handle.

Also, I've just posted new binary packages for 2.0.0_pre, with some surprises.
This is how the pre-release files folder looks like now :
(http://gmic.eu/files/prerelease)

* gmic_cli_* : The G'MIC CLI tool only.
* gmic_lib_* : The G'MIC Libraries only (useful only for a few developers).
* gmic_zart_* : The ZArt interface for real-time webcam processing.
* gmic_qt : The stand-alone Qt interface for G'MIC (not the plug-in!).
* gmic_gimp_gtk_* : The GTK-based plug-in for GIMP.
* gmic_gimp_qt_* : the Qt-based plug-in for GIMP.
* .deb files : Various packages for Debian/Ubuntu systems, contain all the stuffs above.

So, now you should be able to test ZArt and the Qt-based stand-alone G'MIC interface as well, along with the Qt-based plug-in.
A few more binary packages will be posted on tomorrow (for 32bits Windows systems mainly).

Do not hesitate to test and give feedback to what you see !

Thanks !


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Fri Mar 10, 2017 6:46 am  (#74) 
Offline
Global Moderator
User avatar

Joined: May 16, 2010
Posts: 16161
You could just allow for a SET of faves in its own drop down for a certain fave filter. Then you could just save different faves for that filter.

_________________
Image


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Fri Mar 10, 2017 10:04 am  (#75) 
Offline
GimpChat Member
User avatar

Joined: Jan 03, 2011
Posts: 1656
Sometimes you just want to apply a filter based *mainly* on your fave parameters, but with a slight change of one or two parameters only (just because the image you are processing is a bit more like this or like that). I don't think adding 0.1 to one parameter deserves its own fave each time you to that.


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Sat Mar 11, 2017 12:08 am  (#76) 
Offline
GimpChat Member
User avatar

Joined: Sep 24, 2010
Posts: 12832
Remove the gimp_faves file (went again and removed 1.7.9 as well) repaired the issue, David. Copied the GTK 2_0_0 faves into gimp_faves and those faves show up in the QT version and now all's working well, David. Very happy I am; no more nags. :)

_________________
Lyle

Psalm 109:8

Image


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Sat Mar 11, 2017 1:37 am  (#77) 
Offline
GimpChat Member
User avatar

Joined: Jan 20, 2013
Posts: 14831
Location: roma, italy
I don't have GTK 2 faves, did you create yourself, Lyle?

_________________
"Where am I ?"


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Sat Mar 11, 2017 2:34 am  (#78) 
Offline
GimpChat Member
User avatar

Joined: Jan 13, 2011
Posts: 2648
Location: Poland
For 32bit versions anyone can confirm that it works?

_________________
Image


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Sat Mar 11, 2017 7:07 am  (#79) 
Offline
GimpChat Member
User avatar

Joined: Sep 24, 2010
Posts: 12832
dinasset wrote:
I don't have GTK 2 faves, did you create yourself, Lyle?


For the GTK version, David uses gui_faves for the favs. For QT, David imports from gmic_faves (1.7.9) and there had to be some preset I had that gave it a conniption. David posted at the pixls thread that he would someday have to figure out what the issue was, but he has a lot of things on his plate to finish so I'm no longer sweating it. By the way, once QT imports those faves, it makes 1.7.9 faves no longer works. Just be aware of that. I actually had to put 1.7.9 back on my system since there were a lot of Script-fus and python plugins that use the old g'mic. No biggy; just won't be using the old g'mic for processing any longer (will either be using 2_0_0 gtk or 2_0_0 qt. Eventually, g'mic will only use qt (no more updates for gtk). :)

_________________
Lyle

Psalm 109:8

Image


Top
 Post subject: Re: Qt-based G'MIC plug-in
PostPosted: Sat Mar 11, 2017 7:35 am  (#80) 
Offline
GimpChat Member
User avatar

Joined: Jan 03, 2011
Posts: 1656
lylejk wrote:
dinasset wrote:
I don't have GTK 2 faves, did you create yourself, Lyle?


For QT, David imports from gmic_faves (1.7.9) and there had to be some preset I had that gave it a conniption. :)


Just to be clear, I'm not the developer of the qt plug-in, so all credits for the qt interface goes to Sébastien Fourey, my colleague at the lab, who is behind this new development.


Top
Post new topic Reply to topic  [ 204 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6, 7 ... 11  Next

All times are UTC - 5 hours [ DST ]



* Login  



Powered by phpBB3 © phpBB Group