It could be you need to use double slashes in the path.

I wonder if i need to update my Python-2.6 version to Python-2.6.3? Maybe that is why the urllib.py module fails?
Which version of Python are you using on Windows 7?

Rod: I used Python 2.6.4. In fact I followed your instructions from here to install it.

Did you try " gimp --verbose" ?
You may have to replace "gimp" with the full path for gimp.exe (not sure if will work for the 2.7.5 portable maybe in case should be the path for "gimprun.exe"

"gimp --verbose" on Windows is fairly pointless as it isn't in any way verbose.

I've done some debugging by adding this:

And I get the "in Main" message but not the "in Main 2" message. I therefore conclude that the .set_label method doesn't exist in whichever version of gtk/pygtk is being used (Typing gtk.ver into the Python console reveals 2, 14, 2)

Oh, and on my home machine:

So I'm thinking you need to specify the minimum system requirements.

Kevin

paynekj: I'm using Python 2.6.4 on the Windows machine I'm testing on. The json module you're missing was first made a part of Python in version 2.6, though it is possible to manually install it with earlier versions of Python.

I've narrowed the bug down to these lines:



The first line, would strip any spaces and other weird stuff from the path to the original image, and the second line would make a hash out of that path, which matches the name of the thumbnail. This works on Linux, but on Windows I'm getting an incorrect hash. It probably has something to do with Windows using \ and Linux using / in their paths. If anyone has a any ideas, feel free to shout out? I've tried quite a few different things, but all return an incorrect hash so far.

Running pdb.gimp-image-get-filename in Python returns
C:\Documents and Settings\Owner\My Documents\My Pictures\details.png
And the Image properties has it that way as well.

whereas in Script-fu it's:
C:\\Documents and Settings\\Owner\\My Documents\\My Pictures\\details.png

So which is GIMP on Windows using to create the thumbnail filename? I can't answer that, I have GIMP set to not create thumbnails - which would break your script yes/no?

I don't know any script-fu, but it's possible it's just escaping the backslashes. The path is basically the same.

My script uses Gimp to generate the thumbnails, but I'm still having trouble with the part of the code that finds the thumbnails that have been generated to show them in the Book window. It works fine on Linux, but breaks on Windows.

Basically thumbnails are named using the md5 hash of the URI path of the file (e.g. file:///home/ragtag/drawing.xcf). On Windows, I get an md5 hash, it's just not the same as the name of thumbnail generated. I think it has something to do with escaping backslashes, but all the combinations I've tried so far have failed.

I guess I'll have to give it another shot after work tomorrow.

Here's a thought. The spec for thumbnail creation ( http://people.freedesktop.org/~vuntz/thumbnail-spec-cache/thumbsave.html ) makes a point of this:


Which means your code is fine on a linux system because you prefix "file://" onto the front of a path that starts with the third "/". HOWEVER on windows the path doesn't start with a "/", so you are calculating the hash on a non compliant uri.

Kevin

I've done some looking around in the GIMP source code and come across

g_escape_file_uri

Which changes all the backslashes into forward slashes, adds the file:// and the extra / if it's not already there on the front of the filename and uses
g_escape_uri_string with a flag to make sure some characters are not escaped, one of which appears to be the colon ":" and maybe the space?

According to this page: http://unspecified.wordpress.com/2008/05/24/uri-encoding/ it's possible to call urllib.quote and tell it not to escape some characters: urllib.quote(self.imagepath.encode("utf-8"), safe=":")

Kevin

Thanks for the tip. I'll need to look into that.

I got it working on Windows before I read your post. I skipped urllib on Windows, so it probably won't work with Chinese pages names on Windows, like it does on Linux, but at least it works now.

I've updated the file in the Gimp Registry, and even added a screenshot.

Now it works even with Gimp 2.7.5 (XP 32 bit, Python 2.7.2).
Thank You.
Do you plan to add language file (pot)?

Great to hear that it works in 2.7, which means it will probably work in 2.8 when that comes out too. Less re-writing for me.

Adding support for translation files is on my to do list, just not at the very top. As is adding support for right to left reading. On Linux, you can use Chinese, Japanese and so on, names for your pages, but I believe this won't work under Windows (need to test it).

My to do list is at the end of the book.py, if you open it in a text editor.

I hoped something alike from long...for Xmas i had a beautiful gift (Manga studio) but still i am sure that will come still very handy...Gimp miss a similar tool till now ,thank you

Manga Studio is actually great piece of software for making comics, especially black and white ones for print. I own Manga Studio EX and have made a comic book with it, so I can't claim that it wasn't an inspiration for GIMP Book.

I had to update to Python-2.6.4, redo my PATH variable to read Python26 files and i was all set.
The newer update works excellent in Gimp-2.6.11 on Windows XP.
Thanks for a great plug-in Ragtag!
Nicely done.

I just uploaded an updated GIMP Book plug-in to the Gimp Plug-In Registry. I've changed the following:

# - Added storyboard mode, where the pages flow, rather than display in two columns.
# - Added page numbers to title bar.
# - Added right click menu to pages, for quicker access to adding, deleting and renaming pages.
# - Added gimp icon to dialog and windows..
# - Bugfix - Clicking 'No' button in the delete page dialog now works.
# - Bugfix - Window can be made smaller.

I've also tested it briefly in Gimp 2.8 RC1 on Linux, and it seems to work. I haven't tested using the layer tagging with the new layer groups, but I imagine that it could break something. That said, layer groups will be great for doing comics, as you can have one layer group per panel, group speech bubbles together and so on.

Thanks Ragtag!